Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Automatic catalog selection of replication keys #1283

Merged
merged 7 commits into from
Jan 17, 2023
Merged

feat: Automatic catalog selection of replication keys #1283

merged 7 commits into from
Jan 17, 2023

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Dec 19, 2022 •
edited
Loading

Closes #1217

📚 Documentation preview 📚: https://meltano-sdk--1283.org.readthedocs.build/en/1283/

@edgarrmondragon edgarrmondragon linked an issue Dec 19, 2022 that may be closed by this pull request
[Feature]: Automatic catalog inclusion of replication keys #1217
Closed
@edgarrmondragon edgarrmondragon force-pushed the 1217-feature-automatic-catalog-inclusion-of-replication-keys branch from 84b48a8 to 0c15fef Compare December 19, 2022 18:34
@codecov
Copy link

codecov bot commented Dec 19, 2022 •
edited
Loading

Codecov Report

Merging #1283 (dc588a4) into main (efb1142) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head dc588a4 differs from pull request most recent head aa5b6c1. Consider uploading reports for the commit aa5b6c1 to get more accurate results

@@           Coverage Diff           @@
##             main    #1283   +/-   ##
=======================================
  Coverage   84.53%   84.54%           
=======================================
  Files          44       44           
  Lines        4190     4192    +2     
  Branches      725      726    +1     
=======================================
+ Hits         3542     3544    +2     
  Misses        474      474           
  Partials      174      174
Impacted Files Coverage Δ
singer_sdk/_singerlib/catalog.py 98.17% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon marked this pull request as ready for review December 19, 2022 18:46
@edgarrmondragon edgarrmondragon mentioned this pull request Dec 19, 2022
Closed
@visch
Copy link
Contributor

visch commented Dec 20, 2022

@edgarrmondragon awesome stuff! Fixes this one for everybody

@edgarrmondragon
Copy link
Collaborator Author

@kgpayne can you think of any undesired consequences of doing this? I don't think many folks are relying on the replication key not being selected by default. Wdyt?

@edgarrmondragon edgarrmondragon enabled auto-merge (squash) December 20, 2022 23:19
@kgpayne
Copy link
Contributor

kgpayne commented Jan 17, 2023

@edgarrmondragon I can't think of any reason not to select replication keys by default 🙂 Users can always override if necessary too, so seems like a good default behaviour to me 👍

@edgarrmondragon edgarrmondragon merged commit eec6e6a into main Jan 17, 2023
@edgarrmondragon edgarrmondragon deleted the 1217-feature-automatic-catalog-inclusion-of-replication-keys branch January 17, 2023 14:51
@edgarrmondragon edgarrmondragon mentioned this pull request Dec 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgpayne kgpayne kgpayne approved these changes

@cjohnhanson cjohnhanson Awaiting requested review from cjohnhanson

@aaronsteers aaronsteers Awaiting requested review from aaronsteers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Automatic catalog inclusion of replication keys
3 participants
@edgarrmondragon @visch @kgpayne